fix: NavigationTree updates from testing - #10507
Open
snowystinger wants to merge 5 commits into
Open
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
marked this pull request as ready for review
August 25, 2026 03:31
LFDanLu
reviewed
Aug 25, 2026
LFDanLu
left a comment
LFDanLu
left a comment
Member
There was a problem hiding this comment.
LGTM, verified the various bugs fixes locally on desktop/mobile. Just one comment about the docs example since it feels weird to aria hide the buttons
| <NavigationTreeItem id="home" href="/home" textValue="Home"> | ||
| <NavigationTreeItemContent> | ||
| <NavigationTreeItemLink>Home</NavigationTreeItemLink> | ||
| <Button variant="quiet" aria-label="More options"><MoreHorizontal size={16} aria-hidden /></Button> |
Member
There was a problem hiding this comment.
Aria-hidden since it doesn't actually open a menu?
Member
There was a problem hiding this comment.
should it just render a simple menu?
Member
Author
There was a problem hiding this comment.
that's not hiding the button, it's just on the icon, there's an aria label on the button. I didn't want it to render a menu because it'd make the code for the example a lot longer
Member
There was a problem hiding this comment.
oh derp, somehow eyes glazed over the icon, perfectly fine then
yihuiliao
approved these changes
Aug 25, 2026
LFDanLu
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Fixes from testing:
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: